Scheduler "show business hours" leaves big space down below

1 Answer 82 Views
Scheduler
Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
Yiheng asked on 03 Dec 2022, 11:33 AM

Hi there, please also check this recording https://www.loom.com/share/962a4b934ada4b699fb847bf55d55879

1 Answer, 1 is accepted

Sort by
0
Accepted
Vessy
Telerik team
answered on 07 Dec 2022, 02:57 PM

Hi, Yiheng,

The white space in the TimeView is added by design, as the height of the Scheduler is not changed when switching between the views, but is set based on the applied height itself.

As for the issue appearing after the click of the "Show full day" button -  I tried to replicate it in the following demo but to no avail. Can you, please, examine it and see how it differs from the actual setup that you have? does the problem occurs if you upgrade to the latest version of the KendoReact packages and the Kendo UI themes?

https://www.telerik.com/kendo-react-ui/components/scheduler/views/week/#toc-getting-started

If the upgrading does not help, can you modify the sample above up to a point where the issue occurs and send it back so I can examine the root of it further?

Regards,
Vessy
Progress Telerik

Virtual Classroom, the free self-paced technical training that gets you up to speed with Telerik and Kendo UI products quickly just got a fresh new look + new and improved content including a brand new Blazor course! Check it out at https://learn.telerik.com/.

Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 08 Dec 2022, 01:12 PM | edited

Hi Vessy, please check this fork https://stackblitz.com/edit/react-wjwdnv?file=app%2Fmain.tsx

I found if you delete the timezone from <Scheduler>, you could see this issue

Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 08 Dec 2022, 01:36 PM

and the timezone doesn't work for 'Asia/Shanghai' also
Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 12 Dec 2022, 01:13 PM

Hi Vessy, I don't know if you could reproduce this issue, it may be related to the user locale, I'm in 'Asia/Shanghai', and if I delete the "timezone" props from <Scheduler>, I could see the big blank under below. 
Vessy
Telerik team
commented on 12 Dec 2022, 02:30 PM | edited

Hi, Yiheng, I am still not able to replicate the issue - the behavior at my end is the same both before and after deleting the `timezone` prop. I also tried setting the `Asia/Shanghai` timezone esplicitly via the `kendo-date-math library`, but the behvaior was the same:

You can see the sample from my test here:

Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 12 Dec 2022, 03:59 PM

Hi Vessy, now it also works for me, probably I failed to load some styles last time. Thank you very much for double-checking it. 
Vessy
Telerik team
commented on 12 Dec 2022, 04:47 PM

No worries, Yiheng, I am glad everything works properly at your end as well now.
Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 13 Dec 2022, 02:02 PM

Hi Vessy, I think I found the reason, the big blank is caused by the current time indicator, and that explained why it works fine in the daytime.

Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 13 Dec 2022, 02:09 PM

I believe you can reproduce it by manually setting your system time to evening. 
Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 15 Dec 2022, 12:02 PM

Could you confirm this issue? It failed to delete the "top" CSS attribute on the current time indicator, and that would cause a big blank in the evening. 
Filip
Telerik team
commented on 15 Dec 2022, 03:16 PM

Hello, Yiheng,

Vessy is currently out of the office and I will handle the ticket. Apologies for the delayed response.

I tested the following example after I changed the timezone of my machine to Asia/Shanghai timezone, however, I was not able to reproduce the mentioned issue:

https://stackblitz.com/edit/react-wjwdnv-rhaf5r?file=app/main.tsx

Can you verify if this is the correct setup of the component to test and in case it is not provide a reproducible example so that I can test again?

Regards,
Filip

Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 15 Dec 2022, 06:01 PM

Hello Filip, thanks for your reply.

The timezone doesn't matter, you could delete that attribute. 

Please change your system time to the evening such as 20:00 and reload the demo. 

Click "Show full day" and then click "Show business hours", then you would see the big blank at the bottom.

The reason is that the current time indicator has a "top" attribute, it becomes a very large value in the evening, which expands the height of its container. So the solution could be deleting that "top" attribute when clicking "Show business hours".

Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
commented on 15 Dec 2022, 06:17 PM

please also check this recording https://www.loom.com/share/3b7e557cd3704ed4b4c3a61b60d19c48
Filip
Telerik team
commented on 19 Dec 2022, 02:04 PM

Hello, Yiheng,

Thank you for the provided information.

I tested the example again, this time by changing the time to 20:00 and the behavior did reproduce.

I logged this as an issue which can be tracked and monitored here:

https://github.com/telerik/kendo-react/issues/1466

Once the issue has been resolved, the GitHub item will be updated accordingly.

As a small token of gratitude for bringing this to our attention, I have granted you some Telerik points.

Regards,
Filip
Tags
Scheduler
Asked by
Yiheng
Top achievements
Rank 2
Iron
Iron
Iron
Answers by
Vessy
Telerik team
Share this question
or